Skip to content

feat: Take DSN use minidump url#2

Merged
bruno-garcia merged 5 commits into
masterfrom
feature/dsn-parsing-dependence-free
Mar 5, 2019
Merged

feat: Take DSN use minidump url#2
bruno-garcia merged 5 commits into
masterfrom
feature/dsn-parsing-dependence-free

Conversation

@bruno-garcia

Copy link
Copy Markdown
Member

No description provided.

@bruno-garcia bruno-garcia requested a review from mitsuhiko March 4, 2019 21:01

@mitsuhiko mitsuhiko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also make the printing conditional on a debug flag on the options.

Comment thread sentry.cpp Outdated
@bruno-garcia bruno-garcia merged commit 0616e11 into master Mar 5, 2019
@bruno-garcia bruno-garcia deleted the feature/dsn-parsing-dependence-free branch March 11, 2019 14:15
@matepek matepek mentioned this pull request Oct 13, 2019
Strive-Sun added a commit to Strive-Sun/sentry-native that referenced this pull request Dec 26, 2023
Strive-Sun added a commit to Strive-Sun/sentry-native that referenced this pull request May 22, 2024
Strive-Sun added a commit to Strive-Sun/sentry-native that referenced this pull request May 22, 2024
BernhardMarconato referenced this pull request in elgatosf/sentry-native Apr 21, 2026
BernhardMarconato referenced this pull request in elgatosf/sentry-native May 4, 2026
num_breadcrumbs++ and the file write that follows it were not
protected against concurrent calls from multiple threads.  Two threads
calling sentry_add_breadcrumb simultaneously could observe the same
rotation boundary (first_breadcrumb == true) and both overwrite the
breadcrumb file, or write interleaved msgpack to it.

Add a std::mutex (breadcrumb_mutex) to wer_state_t that serialises
the counter read-modify-increment and the subsequent path write as a
single critical section.  This mirrors the mutex-based protection used
by the in-proc and Crashpad backends.

Fixes audit finding: Bug #2 (breadcrumb thread-safety).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants